don't print 'Using realm' unless realm was supplied by ENV var #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly-security-updates Configure dependabot to only create PRs for security updates
…ning fix resource_tracker warning on OSX
|
|
||
| if self.api.account_info.is_same_key(key_id, realm): | ||
| if self.api.account_info.is_same_key(key_id, realm or 'production'): |
There was a problem hiding this comment.
it just so happens that this is wrong, right? bc realm set by --staging should be treated the same as one by B2_ENVIRONMENT_ENV_VAR here, right? Not in scope of this PR, but can you create a ticket?
There was a problem hiding this comment.
I must say I don't quite see why wouldn't it be treated the same right now, but we do have a ticket for rewriting auth from ENV, so I will just add it there - most likely this problem will be resolved during rewrite as a side effect even if does indeed exists.
mjurbanski-reef
force-pushed
the
verbose_only_imp
branch
from
0b221e5 to
e8114e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Backblaze/B2_Command_Line_Tool/issues/949